Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose currency display names #73

Merged
merged 5 commits into from
Apr 13, 2016
Merged

Expose currency display names #73

merged 5 commits into from
Apr 13, 2016

Conversation

camertron
Copy link
Collaborator

See #72

This PR incorporates a few changes:

  1. Adds currency data documentation to the README.
  2. Exposes a few more fields in currency objects (name and code_points).
  3. Rake task that runs js tests now correctly exits with a non-zero code on test failure.
  4. Currency formatter tests now free from test pollution.

@radzinzki

@camertron camertron mentioned this pull request Apr 6, 2016
Open
@arnavk
Copy link
Contributor

arnavk commented Apr 12, 2016

Oops, missed the notification for this PR

👍

@camertron camertron merged commit 20b43da into master Apr 13, 2016
@camertron camertron deleted the currency_display_name branch April 13, 2016 05:26
@camertron
Copy link
Collaborator Author

Thanks @radzinzki!

@ghost
Copy link

ghost commented Jun 2, 2016

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camertron @arnavk