fix: merge parseTweet options correctly. #425
Open
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing implementation overrides the default options with the new ones if provided. In that case, if partial options are provided, this can lead to unexpected errors (Null values in return object) because default values are all reset.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing implementation overrides the default options with the new ones if provided. In that case, if partial options are provided, this can lead to unexpected errors (Null values in return object) because default values are all reset.
Problem
The existing implementation overrides the default options with the new ones if provided. In that case, if partial options are provided, this can lead to unexpected errors (Null values in return object) because default values are all reset.
Solution
Merge correctly such that partial options provided are merged with correct defaults keeping the output sane.
Result
fixes the parseTweet function when partial options are provided.