Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(WIP) Improve support for selecting and downloading changes #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

(WIP) Improve support for selecting and downloading changes #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions gerrit.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1362,5 +1362,24 @@ workspace of the project."

(call-interactively #'gerrit-upload-transient)))

;; DONE split this up into two parts (one that downloads the change and one that opens the overview page sing magit-show-commit
(defun gerrit-download-and-open-overview (changenr)
;; since a simple "is:open" query might return a lot of gerrit-changes, it
;; is possible to filter the returned results by setting an variable
;; called `gerrit-interesting-open-changes-filter'.
(interactive (list
(let
((gerrit-change-singleline-columns '(number branch project subject)))
(gerrit--select-change-from-matching-changes
gerrit-interesting-open-changes-filter))))

(gerrit--init-accounts)
(gerrit-download:--in-known-repo changenr)
;; TODO run magit-show-commit
;; only when the above change is downloaded to avoid window-flickering
(magit-show-commit "HEAD"))



(provide 'gerrit)
;;; gerrit.el ends here