This repository has been archived by the owner on Mar 22, 2023. It is now read-only.
Decouple k8s namespace from run-as-user #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamsimam
reviewed
Apr 29, 2019
| :spec {:replicas min-instances | ||
| :selector {:matchLabels {:app k8s-name | ||
| :waiter-cluster cluster-name}} | ||
| :waiter-cluster cluster-name | ||
| :waiter/user run-as-user}} |
There was a problem hiding this comment.
ANy reason we chose waiter-cluster over waiter/cluster earlier? Does that same restriction still apply for waiter/user?
There was a problem hiding this comment.
Yes, I noticed that too. We should switch to waiter/cluster, but I was planning to open a separate PR for that change.
There was a problem hiding this comment.
Created issue #721 for this.
shamsimam
approved these changes
Apr 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
Decouple k8s objects'
namespacefrom the Waiterrun-as-useroption.Why are we making these changes?
We would like to make the
namespaceindependently configurable from therun-as-user(e.g., via a newrun-in-namespaceWaiter service parameter). Separating thenamespacelogic from therun-as-userlogic is the first step for supporting independent configuration. This also seems like an overall architectural improvement, since the concerns ofrun-as-userand k8snamespaceare semantically distinct.