Keep images volume by default #81
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit sets the helm.sh/resource-policy annotation [0] of the PersistentVolumeClaim to "keep" if the persistence.keep value is true (the default). This makes it so the persistent volume claim is not destroyed when the chart is uninstalled. This saves people from accidentally destroying their entire volume of images whenever they, for example, want to move the chart to a different namespace (which requires uninstalling and reinstalling the chart in the new namespace because the namespace field is immutable). Several other big-name charts use a "keep" resource policy for similar reasons (see [1] and [2]). If the user still wants their PVC to be destroyed, then can either set persistence.keep to false or manually delete it after an uninstall. The helm CLI alerts the user when objects are left around after the chart is uninstalled. [0]: https://helm.sh/docs/howto/charts_tips_and_tricks/#tell-helm-not-to-uninstall-a-resource [1]: https://github.com/traefik/traefik-helm-chart/blob/v10.24.0/traefik/templates/pvc.yaml#L10 [2]: https://github.com/argoproj/argo-helm/blob/argo-cd-5.3.6/charts/argo-cd/templates/crds/crd-application.yaml#L7
|
cc @canterberry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit sets the
helm.sh/resource-policyannotation 0 of thePersistentVolumeClaimto"keep"if thepersistence.keepvalue is true (the default).This makes it so the persistent volume claim is not destroyed when the chart is uninstalled. This saves people from accidentally destroying their entire volume of images whenever they, for example, want to move the chart to a different namespace (which requires uninstalling and reinstalling the chart in the new namespace because the namespace field is immutable).
Several other big-name charts use a
"keep"resource policy for similar reasons (see 1 and 2).If the user still wants their PVC to be destroyed, then can either set
persistence.keeptofalseor manually delete it after an uninstall. The helm CLI alerts the user when objects are left around after the chart is uninstalled.