Add "Organize Imports" command #669
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camerondubas
force-pushed
the
feature/organize-imports
branch
from
f6db969 to
bcd57a6
Compare
camerondubas
changed the title
|
Closing this because Volar-ized Glint gets an Organize Import command "for free" from Volar. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested here #635 (comment), this adds a
Glint: Organize Importscommand. This is a destructive version of the "Sort Imports" command as it removes unused imports while also sorting.These commands are analogous to the TS LSP's Sort/Organize commands.
This was just a matter of passing
skipDestructiveCodeActions: falseto theorganizeImportslanguage service method. As such, I've standardized on using organizeImports instead sortImports in the vscode extension.