Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix glint cli build tests, parity with vue-tsc #740

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Conversation

machty
Copy link
Contributor

@machty machty commented Jul 1, 2024

Per discussions in Discord, I'm pushing Glint v2's cli tools to behave as closely as possible to vue-tsc, which itself behaves much more closely to vanilla tsc. This means breaking changes for people using glint for type-checking as a CLI task, but here are a few reasons this is desirable / forgivable:

  1. The closer we are to Vue's tooling in general, the more we can tap into their larger community, e.g. there might be a confusion about glint that can be well explained by a closed issue in vue-tsc, rather than having this obscured by glint's behind-the-scenes flag-switching before shelling out to vanilla tsc.
  2. Perhaps glint v2 can remove the glint binary and introduce a new one called ember-tsc; this will be a much more loud and obvious breaking change such that anyone searching it can find the correct args to use rather than getting confused between existing and new documentation for glint v1 vs v2.

@machty machty marked this pull request as ready for review July 1, 2024 18:49
@machty machty merged commit c9300e5 into main Jul 1, 2024
1 of 6 checks passed
@machty machty deleted the glint-tsc-fixes branch July 1, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant