Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typed ember/resolve config from extends package #782

Conversation

iarroyo
Copy link
Contributor

@iarroyo iarroyo commented Dec 28, 2024

Resolve glint configuration when your tsconfig.json extends from a package, ex

path: tsconfig.json

{
  "extends": "@package1"
}

path: node_modules/@package1/tsconfig.json

{
  "glint": {
    "environment": ["ember-loose", "ember-template-imports"]
  }
}

@iarroyo
Copy link
Contributor Author

iarroyo commented Dec 28, 2024

Please take a look when you have a chance, thank you
cc @NullVoxPopuli

Copy link
Contributor

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some lint/prettier issue, can you push up a fix? Code looks fine otherwise!

@iarroyo
Copy link
Contributor Author

iarroyo commented Jan 3, 2025

Looks like some lint/prettier issue, can you push up a fix? Code looks fine otherwise!

@NullVoxPopuli it should fix the prettier issue

@NullVoxPopuli NullVoxPopuli added the bug Something isn't working label Jan 3, 2025
@NullVoxPopuli NullVoxPopuli merged commit d8f63e9 into typed-ember:main Jan 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants