Support Google Fonts API version 2 and advanced features from version 1 #437
+61
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 1 (display, effect)
nachaos
approved these changes
Oct 30, 2020
|
Hi @bramstein @jeremiele, adding both of you since you're the contributors with more commits on this project. Is there a chance this PR gets reviewed? Thank you 😃 |
|
Hi @webdev, @benjaminwelch @bramstein ! Any news about this project ? Is it still alive ? |
|
I would also add font weight and style as an object property. 🙄 Anyways, what about the status of the project? Will it get reviewed anytime soon? :D |
|
For those using vitejs/rollup I have made a plugin here: https://github.com/stafyniaksacha/vite-plugin-fonts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the library to work with Google Fonts API version 2. It also includes the font-display feature available for use with both versions of the API, as well as the font-effect feature (currently only available for version 1).