Fix TLS session access on JS #3257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I feel satisfied this is working correctly. Not the first time Node.js TLS docs have been wrong ... |
etspaceman
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a test, but it wasn't working properly for server-side TLS sockets. So I fixed that.
In the end fussing with
'session'events was more complicated and didn't seem to work for server sockets anyway. Even though the docs warn against it for TLS v1.3getSession()seems to work fine 🤔https://nodejs.org/api/tls.html#tlssocketgetsession
Well, let me double-check that before we merge 😅
Another one h/t @etspaceman