Refresh scalac settings

[armanbilge]

• Closes Restore -source:3.2-migration  #474
• Merges Add -Xsource:3 to 2.12 (and future minor 2 releases) builds #493
• Merges Add re-introduced unused/discard warnings for scala >3.3.0 #515
• Heeds Can/should I use both `-Xsource:3` and `-source:3.0-migration` in a cross-compiled codebase? scala/scala3#17591
• Closes tlFatalWarnings and tlJdkRelease don't respect Config, Test, etc. scopes #257

[satorg]

A minor nit: -Xfatal-warnings was superseded with -Werror on 2.13 and 3.x. Although the former seems still working on both compilers.

However, perhaps it makes sense to check for both options in the if condition, like

if (!old.contains(flag) && !old.contains("-Werror")) old :+ flag else old
else
  old.filterNot(opt => opt == flag || opt == "-Werror")

[armanbilge]

Oh, good to know 🤔 do you know which Scala versions that happened in?

I'm kind of okay with sbt-typelevel dropping support for old patches.

[armanbilge]

However, perhaps it makes sense to check for both options in the if condition, like

The if is mainly intended to check for the flag it added itself, since Test seems to inherit from Compile, see #255 (comment).

[satorg]

@armanbilge

Oh, good to know 🤔 do you know which Scala versions that happened in?

looks like -Werror was added since 2.12.17:

$ scala-cli compile --server=false -S 2.12.16 -Werror -Xlint -- UnusedImport.scala 
scalac error: bad option: '-Werror'
  scalac -help  gives more information
Compilation failed

$ scala-cli compile --server=false -S 2.12.17 -Werror -Xlint -- UnusedImport.scala 
UnusedImport.scala:1: warning: Unused import
import scala.concurrent.Future
                        ^
error: No warnings can be incurred under -Xfatal-warnings.
one warning found
one error found
Compilation failed

However, seems it was not announced officially: https://github.com/scala/scala/releases/tag/v2.12.17.
Neither it is returned by any of scalac v2.12.17 help options (I couldn't find any at least).