Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected stale 2.13 version in WorkflowJob #565

Merged
merged 2 commits into from
Jun 24, 2023

Conversation

j-mie6
Copy link
Collaborator

@j-mie6 j-mie6 commented Jun 24, 2023

Bumps 2.13.6 default to 2.13.11 2.13 (matching the behaviour of the generalisation to binary versions). Feel free to close if this is not desired!

@j-mie6
Copy link
Collaborator Author

j-mie6 commented Jun 24, 2023

Is it worth also bumping the Java default there to 17?

@j-mie6 j-mie6 changed the title Bumped stale 2.13 version in WorkflowJob ~~Bumped~~ Corrected stale 2.13 version in WorkflowJob Jun 24, 2023
@j-mie6 j-mie6 changed the title ~~Bumped~~ Corrected stale 2.13 version in WorkflowJob Corrected stale 2.13 version in WorkflowJob Jun 24, 2023
@armanbilge
Copy link
Member

Is it worth also bumping the Java default there to 17?

The bump from 8 to 11 originated in the original repository and was highly controversial.

I basically decided not to touch it 😛

Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@armanbilge armanbilge merged commit d7cc9b0 into typelevel:main Jun 24, 2023
@j-mie6 j-mie6 deleted the patch/bump-scala-2.13-workflowjob branch June 24, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants