Provide non-DSL spellings of primitives #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexhuang91 I'm unable to tag you as a reviewer, but I would still like you to review this. |
alexhuang91
approved these changes
Dec 28, 2017
alexhuang91
approved these changes
Jan 2, 2018
|
⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
#261 requests a way to spell the testing primitives without using the DSL.
What's worth discussing about this pull request?
Operators in Swift have a complex and storied history, and their use outside of the standard library is the subject of a lot of styling debates. Many frameworks that choose to provide custom operators do so because they are trying to mimic a particular syntax or structure. The trap many fall into is not providing a way out of the DSL.
What downsides are there to merging this pull request?
On the other hand, SwiftCheck's DSL isn't just a matter of syntax. Tests are data in this framework, and can be stored and computed with.
<-indicates when you want to statement-ize that data and execute the test. Providing an out dilutes that philosophy.