Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added correct typing for has one create mixin values. #189

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ranguna
Copy link

@Ranguna Ranguna commented Oct 21, 2020

Hello everyone!
I'm trying to make a wrapper around sequelize mixins and I stumbled upon this.
If I understood the mixing correctly, the createModel mixin for hasOne association does not seem to have the correct typing for the creation values (accessible from Model["_creationAttributes"]).

Do these changes make sense ?

If yes, I can replicate them to all other association types.

@Ranguna
Copy link
Author

Ranguna commented Oct 21, 2020

Also, I just realized that I have a typo in the commit message, I can redo the commit if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant