Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webapp): add an "add project" page #31

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

W95Psp
Copy link
Collaborator

@W95Psp W95Psp commented Feb 16, 2024

This commit splits the "Projects" component into two smaller ones, and gets rid of the form to add a project. Instead, this commit introduces a separate page for creating projects.

This commit introduces the module `page/error.rs` that defines a few
components to display various error in a uniform way.
@W95Psp W95Psp requested a review from pnmadelaine February 16, 2024 22:11
@W95Psp W95Psp force-pushed the lucas/add-project-page branch from 9013d69 to a6806d2 Compare February 16, 2024 22:12
@W95Psp W95Psp changed the base branch from main to lucas/gather-errors-in-module February 16, 2024 22:12
@W95Psp W95Psp force-pushed the lucas/add-project-page branch from a6806d2 to 2a9e272 Compare February 16, 2024 22:26
@W95Psp W95Psp changed the base branch from lucas/gather-errors-in-module to lucas/improve-request-action February 16, 2024 22:28
This is useful to process the result of the `handle_request` within
the server action, or to perform some side effect before returning.
This commit split the "Projects" component in two smaller ones, and
get rid of the form to add a project.

Instead, this commit introduces a separate page for creating projects.
@W95Psp W95Psp force-pushed the lucas/add-project-page branch from 2a9e272 to 2f5f5bf Compare February 16, 2024 22:30
Base automatically changed from lucas/improve-request-action to main February 18, 2024 10:25
Copy link
Member

@pnmadelaine pnmadelaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the details from the options, this kind of implies that a flake will "just work" with Typhon, when actually we require the typhonProject attribute to be set. Similarly, a "legacy" project does not actually require a default.nix but a nix/typhon.nix.

@W95Psp
Copy link
Collaborator Author

W95Psp commented Feb 18, 2024

Then I can add those details and even maybe link to the documentation, WDYT?

<ActionForm action>
<div class="header">"Add a project"</div>
<div class="header-description sep">
"Add continuous integration with Typhon for an existing codebase. This project will be visible to anyone that have access to this Typhon instance."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "Import a project's declaration to Typhon. This project will be visible to anyone with access to this Typhon instance."?

@W95Psp
Copy link
Collaborator Author

W95Psp commented Feb 18, 2024

Eg, "a flake with Typhon enabled", where Typhon enabled is a link to the doc, and similar for legacy

@pnmadelaine
Copy link
Member

Then I can add those details and even maybe link to the documentation, WDYT?

Aesthetically, I would keep the options clean, and add a link to the documentation below, maybe with a comment like "To learn more about project declarations, visit the documentation at https://typhon-ci.org".

@pnmadelaine
Copy link
Member

Apart from my comments on the text to display, this is a really nice page :)

@pnmadelaine pnmadelaine changed the title feat(webapp): add a "add project" page feat(webapp): add an "add project" page Feb 18, 2024
@pnmadelaine
Copy link
Member

I just noticed, this PR seems to break the display of our very nice logo :(

@W95Psp W95Psp self-assigned this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants