Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sink): Add schema generator for argument sink types #15

Merged
merged 16 commits into from
Jun 2, 2024
Merged

feat(sink): Add schema generator for argument sink types #15

merged 16 commits into from
Jun 2, 2024

Conversation

jamesrswift
Copy link
Member

@jamesrswift jamesrswift commented Jun 2, 2024 •
edited
Loading

Implements schema generator for argument sink types, as described in #12.

To do:

  • Implement schema generator
  • Implement thorough testing
  • Add to documentation

@jamesrswift jamesrswift linked an issue Jun 2, 2024 that may be closed by this pull request
Add schemas for argument sinks #12
Closed
tingerrr
tingerrr requested changes Jun 2, 2024
View reviewed changes
Copy link
Member

@tingerrr tingerrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you forgot to format this, lots of inconsistent spacing.

@jamesrswift jamesrswift changed the base branch from main to next June 2, 2024 16:18
@jamesrswift jamesrswift marked this pull request as ready for review June 2, 2024 16:31
tingerrr
tingerrr reviewed Jun 2, 2024
View reviewed changes
Copy link
Member

@tingerrr tingerrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a few suggestions that are not too problematic, I may have missed a few and I don't think they need to be changed, but I find the personally unidiomatic.

I'm surprised the formatter doesn't impose those.

tingerrr
tingerrr approved these changes Jun 2, 2024
View reviewed changes
Copy link
Member

@tingerrr tingerrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can be merged, I think.

@jamesrswift jamesrswift merged commit e1c967d into next Jun 2, 2024
@tingerrr tingerrr deleted the 12-add-schemas-for-argument-sinks branch June 2, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tingerrr tingerrr tingerrr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add schemas for argument sinks
2 participants
@jamesrswift @tingerrr