-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add named schemas for missing built in types #18
Merged
jamesrswift
merged 17 commits into
main
from
13-add-named-schemas-for-missing-built-in-types
Jun 7, 2024
Merged
Changes from 15 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
b21cc64
feat(gradient): Add gradient schema generator
jamesrswift 3148bad
feat(stroke): Add stroke schema generator
jamesrswift 91bfd52
feat(version): Add version schema generator
jamesrswift 5356648
Merge branch 'next' into 13-add-named-schemas-for-missing-built-in-types
jamesrswift 763ab86
Add more types
jamesrswift 87e0e15
feat(alignment): Add type
jamesrswift 900e4c5
Merge remote-tracking branch 'origin/main' into 13-add-named-schemas-…
jamesrswift 69ef668
Add plugin type
jamesrswift a0391d6
Add angle, direction, and fraction
jamesrswift 7608c37
Add length, ratio, and relative types
jamesrswift 2e0b904
Resolve merge conflict
jamesrswift 9701e16
update style
jamesrswift 62da9b2
Clean tests
jamesrswift 44d7ae3
Fix name on plugin schema
jamesrswift ddb17b4
Update docs
jamesrswift 79a1eef
Merge branch 'main' into 13-add-named-schemas-for-missing-built-in-types
jamesrswift 72e8807
Update string test
jamesrswift File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
#import "/src/lib.typ" as z | ||
#import "/tests/utility.typ": * | ||
|
||
#show: show-rule.with(); | ||
|
||
#let schema = z.gradient() | ||
|
||
= types/gradient | ||
== Input types | ||
#let _ = z.parse(gradient.linear(..color.map.rainbow), schema) |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
#import "/src/lib.typ" as z | ||
#import "/tests/utility.typ": * | ||
|
||
#show: show-rule.with(); | ||
|
||
#let schema = z.stroke() | ||
|
||
= types/stroke | ||
== Input types | ||
#let _ = z.parse(stroke(), schema) |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
#import "/src/lib.typ" as z | ||
#import "/tests/utility.typ": * | ||
|
||
#show: show-rule.with(); | ||
|
||
#let schema = z.version() | ||
|
||
= types/version | ||
== Input types | ||
#let _ = z.parse(version(0, 1, 0), schema) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little concerned about this one,
length
andratio
will not have the same methods asrelative
for example,z.parse
would return whatever type is passed without converting it to a relative.This can be problematic, as shown here.
Should we be less permissive about the types or add a default post-transformation?