Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove choose.delimiter as per CSL spec #16

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove choose.delimiter as per CSL spec #16

wants to merge 1 commit into from

Conversation

YDX-2147483647
Copy link

Resolves #15
Relates-to: typst/hayagriva#269

PgBiel
PgBiel approved these changes Feb 1, 2025
View reviewed changes
Copy link
Contributor

@PgBiel PgBiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, the CSL spec seems to agree, and running rg -i 'choose.+delimiter=' on the official styles repository returns no results either. Though I wonder why it was here in the first place.

@PgBiel PgBiel requested a review from reknih February 1, 2025 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PgBiel PgBiel PgBiel approved these changes

@reknih reknih Awaiting requested review from reknih

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

struct Choose should not have a delimiter field
2 participants
@YDX-2147483647 @PgBiel