Skip to content

Fix some gendered emoji #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix some gendered emoji #104

wants to merge 2 commits into from

Conversation

T0mstone
Copy link
Collaborator

@T0mstone T0mstone commented Jul 4, 2025

People with Bunny ears

These have been changed to be gender-neutral (in Unicode 9.0, according to this).

I also added the gender-specific ZWJ sequences while I was at it, since multi-character symbols are now possible.

Source: https://www.unicode.org/reports/tr51/#multiperson_gender

People holding hands

This is a ZWJ sequence, unlike the other three legacy variants.
I feel like this one only makes sense to also have, now that we can.


Not sure if we should actually merge this before typst#6489, but it's probably fine since I'm pretty sure that that will land before the next release.

@Enivex
Copy link
Collaborator

Enivex commented Jul 4, 2025

I feel like we need a more intelligent way to deal with gender and skin color in emojis. It would be a gargantuan task to do manually.

@T0mstone
Copy link
Collaborator Author

T0mstone commented Jul 4, 2025

For sure, but I came across these while implementing #51 and fixing them like this should be fine for now.

@T0mstone
Copy link
Collaborator Author

T0mstone commented Jul 4, 2025

Or, well, the bunny fix helps with an issue I came across. The other one is just nice to have anyway and serves as a specific patch since the handholding emoji are quite special in being explicitly gendered whereas most others are now gender-neutral by default.

As an aside, I also noticed how the variants for emoji.handholding are defined with redundant modifiers, but that's also observable via repr, so I didn't wanna change it here.

Copy link
Collaborator

@knuesel knuesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a strict improvement. If we later do something smarter for gendered emojis in a breaking way, that would also break the existing dancing.women.bunnny anyway...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants