Skip to content

Add missing arc modifier to angle.right.dot, rename angle.right.sq #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Enivex
Copy link
Collaborator

@Enivex Enivex commented Jul 4, 2025

⦝ is specifically ⊾ with a dot, and .sq should mean a "squarified" version of a symbol (as opposed to .square)

Alternatively we could rename angle.right.sq to angle.right.square instead, but that would be a breaking change.

@MDLC01
Copy link
Collaborator

MDLC01 commented Jul 5, 2025

I am fine with the change from angle.right.dot to angle.right.arc.dot.

I'm not sure why we would want ⦜ to be a variant of angle.right.arc?

@Enivex
Copy link
Collaborator Author

Enivex commented Jul 5, 2025

I am fine with the change from angle.right.dot to angle.right.arc.dot.

I'm not sure why we would want ⦜ to be a variant of angle.right.arc?

Because they both have an arc, but one is drawn using straight lines ("squarified"). It's similar to union and union.sq.

@MDLC01
Copy link
Collaborator

MDLC01 commented Jul 5, 2025

You can also see it as one having an arc and the other having a square. An arc is typically a portion of a circle.

I don't think formal definitions matter that much (what does is users' perception of what an "arc" is), but, to quote Wikipdia, "an arc [...] is a connected subset of a differentiable curve." A square is not a differentiable curve.

@Enivex
Copy link
Collaborator Author

Enivex commented Jul 5, 2025

Like I mentioned, we can also call it angle.right.square. It's a better name in my opinion, but also a breaking change.

@MDLC01
Copy link
Collaborator

MDLC01 commented Jul 5, 2025

Then I would be in favor of using .square.

@T0mstone
Copy link
Collaborator

T0mstone commented Jul 5, 2025

If we're going to start making modifiers globally consistent, I'm going to demand keeping them in a markdown file in the repo (like I already mentioned once or twice on Discord)

@Enivex
Copy link
Collaborator Author

Enivex commented Jul 5, 2025

If we're going to start making modifiers globally consistent, I'm going to demand keeping them in a markdown file in the repo (like I already mentioned once or twice on Discord)

It's not always possible to make everything 100% consistent, but it's always been a goal to try. I guess we could try to write down some general guidelines at least.

@Enivex Enivex added the breaking This involves a breaking change label Jul 5, 2025
@Enivex Enivex changed the title Add missing arc modifier to angle.right.dot and angle.right.sq Add missing arc modifier to angle.right.dot, rename angle.right.sq Jul 6, 2025
@Enivex
Copy link
Collaborator Author

Enivex commented Jul 6, 2025

Then I would be in favor of using .square.

I've made the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This involves a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants