-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gender symbols (Proposal 1) #2
base: main
Are you sure you want to change the base?
Conversation
[meta] Would a 'breaking change' label be useful? |
Also CC @laurmaedje; could we devise some united protocol with typst/typst for deprecating and eventually removing symbols? |
That's a good idea. I created
breaking
I think removing symbols is fine in most cases. It is unlikely that we will change commonly used symbols, and even so, I don't think it would be worse the burden of implementing such a protocol. |
Yeah, some sort of deprecation mechanism would be nice. But Typst doesn't even have that for any kind of constant yet, so we'd need to start there, maybe via some mechanism for deprecated entries of a |
Not sure how to deal with those hybrid thingies, which are sometimes emojis and some not. Doesn't removing it from Slightly related are modifiers for skin tone etc. which should probably not be added by hand. Side note: If we want to support multiple codepoints that could also have an effect on #9. |
I agree it would probably make more sense in the long term to use clusters (probably exposed as strings) instead of codepoints. I just did not think it was an issue in this case. If we do not decide to change that now, I see two options regarding this PR:
|
I think I'd be okay with the latter, I just don't want to remove it if we're gonna add it back anyway. |
This PR is no longer breaking |
Description
This PR implements Proposal 1 (iteration
23) from the Symbol Proposals document. It adds gender symbols under a newsym.gender
sub-module,and removes the old.emoji.transgender
symbolBreaking changes (cc. @laurmaedje)
No breaking change as of iteration 3 (07bfd31).emoji.transgender
is no longer valid.