Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gender symbols (Proposal 1) #2

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

MDLC01
Copy link
Collaborator

@MDLC01 MDLC01 commented Nov 15, 2024

Description

This PR implements Proposal 1 (iteration 2 3) from the Symbol Proposals document. It adds gender symbols under a new sym.gender sub-module, and removes the old emoji.transgender symbol.

Breaking changes (cc. @laurmaedje)

emoji.transgender is no longer valid. No breaking change as of iteration 3 (07bfd31).

@emilyyyylime
Copy link
Collaborator

[meta] Would a 'breaking change' label be useful?

@emilyyyylime
Copy link
Collaborator

Also CC @laurmaedje; could we devise some united protocol with typst/typst for deprecating and eventually removing symbols?

@MDLC01
Copy link
Collaborator Author

MDLC01 commented Nov 18, 2024

[meta] Would a 'breaking change' label be useful?

That's a good idea. I created breaking This involves a breaking change .

could we devise some united protocol with typst/typst for deprecating and eventually removing symbols?

I think removing symbols is fine in most cases. It is unlikely that we will change commonly used symbols, and even so, I don't think it would be worse the burden of implementing such a protocol.

@MDLC01 MDLC01 added the breaking This involves a breaking change label Nov 18, 2024
@laurmaedje
Copy link
Member

Also CC @laurmaedje; could we devise some united protocol with typst/typst for deprecating and eventually removing symbols?

Yeah, some sort of deprecation mechanism would be nice. But Typst doesn't even have that for any kind of constant yet, so we'd need to start there, maybe via some mechanism for deprecated entries of a Scope.

@laurmaedje
Copy link
Member

Not sure how to deal with those hybrid thingies, which are sometimes emojis and some not. Doesn't removing it from emoji reduce our emoji coverage? Perhaps we should rather opt for suporting variation selectors in codex (by exposing strings rather than chars probably?) and force one to the emoji and one to the text presentation.

Slightly related are modifiers for skin tone etc. which should probably not be added by hand.

Side note: If we want to support multiple codepoints that could also have an effect on #9.

@MDLC01
Copy link
Collaborator Author

MDLC01 commented Nov 26, 2024

I agree it would probably make more sense in the long term to use clusters (probably exposed as strings) instead of codepoints. I just did not think it was an issue in this case.

If we do not decide to change that now, I see two options regarding this PR:

  • Close it for now;
  • Keep emoji.transgender for now, and add the appropriate variation selectors later.

@laurmaedje
Copy link
Member

I think I'd be okay with the latter, I just don't want to remove it if we're gonna add it back anyway.

@MDLC01
Copy link
Collaborator Author

MDLC01 commented Nov 27, 2024

This PR is no longer breaking

@MDLC01 MDLC01 removed the breaking This involves a breaking change label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants