-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code organization and bug fix #32
Conversation
More info about esformatter: https://github.com/millermedeiros/esformatter Supported editors: https://github.com/millermedeiros/esformatter#ide--editor-integration
isNode can be confusing (e.g: is a xml node)
Typo: opts.attrsPref -> opts.attrPrefix
To minify: npm run minify
Wow, thanks a lot! Good that you've spotted my conflict-resolving mistake. 💯 This is now all merged and released as version I'd say that this is now quite close to something we could call version |
I think that fix the inconsistency with XML Prolog is a good idea. I will open an issue, then we can continue the discussion. |
Issue #33 opened. If you want, I can try to fix 👍 |
and not also over protoypally inherited ones (regression in #32)
منصةشليلة 2020 |
I started renaming the file index.js to jxon.js then I included some files to orient the code organization (.editorconfig, .esformatter later .eslintrc), changed little things and fixed a bug.
About the bug: as you can see here and here, the merge 45dd8af introduces a unknown attribute (attrsPref). On another commit e6e5ecb, the variable isNode introduces a problem with
xmlns
.I have also changed the test case
multiple nodes should iterate
. The problem here was that<val>foo</val><val>foo</val>
is not a valid XML, so the browsers can't parse that correctly. The test was failing on Firefox, reporting a false positive on Chrome and passing on xmldom.