Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code organization and bug fix #32

Merged
merged 9 commits into from
Aug 14, 2016
Merged

Code organization and bug fix #32

merged 9 commits into from
Aug 14, 2016

Conversation

laubstein
Copy link
Contributor

I started renaming the file index.js to jxon.js then I included some files to orient the code organization (.editorconfig, .esformatter later .eslintrc), changed little things and fixed a bug.

About the bug: as you can see here and here, the merge 45dd8af introduces a unknown attribute (attrsPref). On another commit e6e5ecb, the variable isNode introduces a problem with xmlns.

I have also changed the test case multiple nodes should iterate. The problem here was that <val>foo</val><val>foo</val> is not a valid XML, so the browsers can't parse that correctly. The test was failing on Firefox, reporting a false positive on Chrome and passing on xmldom.

@tyrasd tyrasd merged commit 2b73a5b into tyrasd:master Aug 14, 2016
@tyrasd
Copy link
Owner

tyrasd commented Aug 14, 2016

Wow, thanks a lot! Good that you've spotted my conflict-resolving mistake. 💯 This is now all merged and released as version 2.0.0-beta.3.

I'd say that this is now quite close to something we could call version 2.0.0. The only thing I'm still thinking to add would be a flag to .jsToString which indicates that an XML-declaration should be included in the serialized XML string output (the XML-declaration is one of those few things that gets lost when doing something like JXON.jsToString(JXON.stringToJs('<?xml version="1.0" encoding="UTF-8"?><a>1</a>'))). What do you think? //cc @igord

@laubstein
Copy link
Contributor Author

I think that fix the inconsistency with XML Prolog is a good idea. I will open an issue, then we can continue the discussion.

@laubstein
Copy link
Contributor Author

Issue #33 opened. If you want, I can try to fix 👍

tyrasd added a commit that referenced this pull request May 2, 2017
and not also over protoypally inherited ones

(regression
 in #32)
@vipvi1
Copy link

vipvi1 commented Jan 12, 2020

منصةشليلة 2020
Robotframeworkshliilhplatform
Shliilh.pdf
[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants