Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Raspberry pi support #8

Open
wants to merge 34 commits into
base: master
Choose a base branch
from
Open

Conversation

spaniakos
Copy link

hello there, the library is functioning correctlly to raspberry pi as well.

@tzikis
Copy link
Owner

tzikis commented Dec 1, 2014

Thanks Giorgo! It looks great, but I'd like to dedicate some time into properly reviewing this, so I'll merge it in the near future.

@spaniakos
Copy link
Author

Np , as much as you like.
On Dec 1, 2014 7:55 PM, "Vasilis Georgitzikis" [email protected]
wrote:

Thanks Giorgo! It looks great, but I'd like to dedicate some time into
properly reviewing this, so I'll merge it in the near future.


Reply to this email directly or view it on GitHub
#8 (comment).

@spaniakos
Copy link
Author

now the library supports HMAC

@tzikis
Copy link
Owner

tzikis commented Feb 25, 2015

Holy moly, Giorgo thanks for the updates.

I am very tempted to just accept the changes, but it goes against my spirit of reviewing changes like that and, since I know that people looking for this will probably also be able to find your fork, I am keeping the ticket open until I can dedicate the time to review it properly. I hope you don't mind

@spaniakos
Copy link
Author

Kanena thema.

:-) me ths isixua sou
On Feb 25, 2015 2:25 AM, "Vasilis Georgitzikis" [email protected]
wrote:

Holy moly, Giorgo thanks for the updates.

I am very tempted to just accept the changes, but it goes against my
spirit of reviewing changes like that and, since I know that people looking
for this will probably also be able to find your fork, I am keeping the
ticket open until I can dedicate the time to review it properly. I hope you
don't mind


Reply to this email directly or view it on GitHub
#8 (comment).

@spaniakos
Copy link
Author

Thelw na kanw kai mia allagh akoma .
To digest na eibgebej by default san digest kai me ena flag na mporei na
gurnaei san string opos einai twra.
On Feb 25, 2015 8:41 AM, "spaniakos" [email protected] wrote:

Kanena thema.

:-) me ths isixua sou
On Feb 25, 2015 2:25 AM, "Vasilis Georgitzikis" [email protected]
wrote:

Holy moly, Giorgo thanks for the updates.

I am very tempted to just accept the changes, but it goes against my
spirit of reviewing changes like that and, since I know that people looking
for this will probably also be able to find your fork, I am keeping the
ticket open until I can dedicate the time to review it properly. I hope you
don't mind


Reply to this email directly or view it on GitHub
#8 (comment).

@tzikis
Copy link
Owner

tzikis commented Feb 25, 2015

cool, but let's keep it in english since this is a public issue ;)

@spaniakos
Copy link
Author

Sorry i forgot .

I am in spain for some more days and the time was way to early :-)
On Feb 25, 2015 10:24 AM, "Vasilis Georgitzikis" [email protected]
wrote:

cool, but let's keep it in english since this is a public issue ;)


Reply to this email directly or view it on GitHub
#8 (comment).

jwd83 and others added 3 commits January 10, 2018 18:07
The timing calculation shouldn't take into account the Serial.print("done. ("); call.
The timing calculation shouldn't take into account the Serial.print("done. ("); call.
@beicnet
Copy link

beicnet commented Feb 8, 2020

Nice, after 5-6 years still not reviewed and merged! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants