Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest Go and u-root #229

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rjoleary
Copy link
Contributor

This should fix the dependabot warnings.

This change also adds support for building the initramfs on Mac and makes the switch to using Go modules.

Tested with task -fv core:loader

Signed-off-by: Ryan O'Leary [email protected]

@rjoleary rjoleary requested a review from rminnich February 10, 2023 07:41
@rjoleary rjoleary force-pushed the dependabot branch 2 times, most recently from 2ceb1bb to d787e4e Compare February 12, 2023 17:37
@rjoleary
Copy link
Contributor Author

I don't understand Go modules. The error is:

[image:rootfs] 	go get github.com/u-root/cmds/core/backoff
[image:rootfs] 	* package github.com/u-root/cmds/core/basename: -: no required module provides package github.com/u-root/cmds/core/basename; to add it:
[image:rootfs] 	go get github.com/u-root/cmds/core/basename
[image:rootfs] 	* package github.com/u-root/cmds/core/bind: -: no required module provides package github.com/u-root/cmds/core/bind; to add it:
[image:rootfs] 	go get github.com/u-root/cmds/core/bind
[image:rootfs] 	* package github.com/u-root/cmds/core/blkid: -: no required module provides package github.com/u-root/cmds/core/blkid; to add it:
[image:rootfs] 	go get github.com/u-root/cmds/core/blkid
[image:rootfs] 	* package github.com/u-root/cmds/core/cat: -: no required module provides package github.com/u-root/cmds/core/cat; to add it:

The github.com/u-root/u-root is inside the go.mod, so I expect this to work.

@rjoleary
Copy link
Contributor Author

I don't understand Go modules. The error is:

[image:rootfs] 	go get github.com/u-root/cmds/core/backoff
[image:rootfs] 	* package github.com/u-root/cmds/core/basename: -: no required module provides package github.com/u-root/cmds/core/basename; to add it:
[image:rootfs] 	go get github.com/u-root/cmds/core/basename
[image:rootfs] 	* package github.com/u-root/cmds/core/bind: -: no required module provides package github.com/u-root/cmds/core/bind; to add it:
[image:rootfs] 	go get github.com/u-root/cmds/core/bind
[image:rootfs] 	* package github.com/u-root/cmds/core/blkid: -: no required module provides package github.com/u-root/cmds/core/blkid; to add it:
[image:rootfs] 	go get github.com/u-root/cmds/core/blkid
[image:rootfs] 	* package github.com/u-root/cmds/core/cat: -: no required module provides package github.com/u-root/cmds/core/cat; to add it:

The github.com/u-root/u-root is inside the go.mod, so I expect this to work.

It looks like I need to change github.com/u-root to github.com/u-root/u-root. I'll fix this then, attend to this next error:

[image:rootfs] 	* package github.com/u-root/u-bmc/cmd/socat: -: no required module provides package github.com/u-root/u-bmc/cmd/socat; to add it:
[image:rootfs] 	go get github.com/u-root/u-bmc/cmd/socat

This should fix the dependabot warnings.

This change also adds support for building the initramfs on Mac and
makes the switch to using Go modules.

Tested with `task -fv core:loader`

Signed-off-by: Ryan O'Leary <[email protected]>
@rjoleary
Copy link
Contributor Author

Above errors have been fixed. The latest error is:

[image:rootfs] 2023/02/16 15:37:42 finding packages failed: failed to add package github.com/u-root/u-root/cmds/core/basename for errors: 1 error occurred:
[image:rootfs] 	* /home/circleci/go/pkg/mod/github.com/u-root/[email protected]/cmds/core/basename/basename.go:19:7: could not import github.com/spf13/pflag (invalid package name: "")
[image:rootfs] 
task: Failed to run task "build": task: Failed to run task "platform:build-qemu-virt-a72": task: Failed to run task "image:rootfs": exit status 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant