modified to support current pyuarm (2.x) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I modifed the uarm function calls to make them compatible with the current pyuarm.
Positive y-coordinates were converted to negative values, which did not worked - i turned the condition in order to convert negative values to positive ones and it works.
In addition, I fixed the base.STL because rviz throwed a warning ("... the STL file is malformed ...").
Functionality tested of :
However, there is still an issue that sometimes the command does not get executed and the node throwes an error which raltes to rospy tcpros_base.py. Another problem is the not proper working visual_control.py node (could be my fault because of the configuration). I'll do further testing on both issues and will report as soon as I found something out.