Banner ads in body text on Modrinth and Curseforge

[raqean]

More specific filters are needed as sometimes the banner ads don't include a link and need to be filtered differently. This filter uses the alt text but other approaches may also be viable (such as using the text of the preceding h2, or both).

URL(s) where the issue occurs

• https://modrinth.com/mod/embeddium
• https://www.curseforge.com/minecraft/mc-mods/embeddium

Describe the issue

Banner ads in body text

Screenshot(s)

Versions

• Browser/version: Firefox 134.0.2 (64-bit)
• uBlock Origin version: uBlock Origin 1.62.0

Settings

Notes

The h2 text preceding each of these ads is also technically part of the ad but I haven't found an easy way to include it in the filter without being overly broad. I'm open to suggestions and/or changes by maintainers to incorporate this.

[stephenhawk8054]

Those are unclickable so I'm not sure if it should be addressed. Better to report to EasyList anyways.

@Yuki2718 What do you think?

[uBlock-user]

Once we add filters for a site, we should fix the remaining issues with the site too.

[stephenhawk8054]

Our previous filters were actually for testing first. After there are no breakages reported with them, they were moved to EasyList. Currently EL is already having a bunch of our previous filters (and ours are already removed in uAssets respectively).

[uBlock-user]

So we should remove duplicates then.

[stephenhawk8054]

Yeah, we already removed a lot of duplicates. Not sure how many are left.

[krystian3w]

@stephenhawk8054 Duplicate filters character within character (line) are only:

modrinth.com##a[rel*="sponsored"]:upward(.normal-page__content > div)
modrinth.com##section.normal-page__content :is([href^="https://ModdersAgainstBlockers.github.io"],[href*="/kinetic/"],[href*="/creeperhost"],[href^="https://fxco.ca/assets/"],[href^="https://rb.gy/"]) > img
modrinth.com##section.normal-page__content [href^="https://bisecthosting.com/"][href*="?r="] img
modrinth.com##section.normal-page__content a[href*="/redirect/"] img
curseforge.com##:is(.project-description,div.project-detail__content) [href^="/linkout?remoteUrl=http"]:is([href*="fxco.ca"]) > img
curseforge.com##+js(nano-sib)

https://pastebin.com/raw/hjHLguTh

So the rest were addressed differently or not included in EasyList.

[Yuki2718]

Unsure too, usually I don't block mere images but looks their only purpose is advertising. @ryanbr