Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSE-288: more Java 11 updates #228

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

groybal
Copy link
Contributor

@groybal groybal commented Jan 12, 2023

More Java 11 updates:

  • fix logging
  • add Java 11 to github build
  • fix dom4j NoSuchMethodError issue due to two versions of dom4j jars in WEB-INF/lib

@@ -175,11 +183,23 @@
<groupId>commons-httpclient</groupId>
<artifactId>commons-httpclient</artifactId>
<version>3.1</version>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

48% of developers fix this issue

High Vulnerability:

maven : commons-httpclient/commons-httpclient : 3.1

0 Critical, 1 High, 1 Medium, 0 Low vulnerabilities have been found across 1 dependencies.
View the Lift console for details about these vulnerabilities.


ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More broadly we probably want to migrate to the new maven package for httpclient
v3: https://mvnrepository.com/artifact/commons-httpclient/commons-httpclient (currently used)
v4: https://mvnrepository.com/artifact/org.apache.httpcomponents/httpclient
v5: https://mvnrepository.com/artifact/org.apache.httpcomponents.client5/httpclient5

But that may be outside the scope of the Java 11 upgrade

@@ -327,26 +359,26 @@
<version>1.1.2</version>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

48% of developers fix this issue

High Vulnerability:

maven : taglibs/standard : 1.1.2

0 Critical, 1 High, 0 Medium, 0 Low vulnerabilities have been found across 1 dependencies.
View the Lift console for details about these vulnerabilities.


ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.


Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package has moved in maven central.
We probably want switch to the new package https://mvnrepository.com/artifact/org.apache.taglibs/taglibs-standard-impl at some point.
That may not be needed as part of the Java 11 upgrade.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created issue #230 to handle this one too! Thanks Christian

@groybal
Copy link
Contributor Author

groybal commented Jan 12, 2023

How do we handle the sonatype-lift issues?

@ChristianMurphy
Copy link
Member

How do we handle the sonatype-lift issues?

If you have some time available, it would be great to upgrade those dependencies.
But that doesn't strictly need to happen as part of the Java 11 upgrade, note them down for later review/resolution.

@loulou2u loulou2u self-requested a review January 17, 2023 19:08
Copy link
Collaborator

@loulou2u loulou2u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for Java 11 scope, but created issue #229 and #230 to address migrating to new maven package for httpclient..and taglibs-standard-impl. Thanks Christian and Gary!

@loulou2u loulou2u merged commit b96734e into uPortal-Project:feat/java11-upgrade Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants