-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/SessionReplicationAop #633
base: master
Are you sure you want to change the base?
feat/SessionReplicationAop #633
Conversation
handlers = 1catalina.org.apache.juli.AsyncFileHandler, 2localhost.org.apache.juli.AsyncFileHandler, 3manager.org.apache.juli.AsyncFileHandler, 4host-manager.org.apache.juli.AsyncFileHandler, 5aop-serializer.org.apache.juli.AsyncFileHandler, java.util.logging.ConsoleHandler | ||
|
||
.handlers = 1catalina.org.apache.juli.AsyncFileHandler, 5aop-serializer.org.apache.juli.AsyncFileHandler, java.util.logging.ConsoleHandler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the difference between a handler
and a .handler
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logging.properties comes directly from apache tomcat (https://tomcat.apache.org/tomcat-8.0-doc/logging.html). I don't understand what each of the configurations are for; I just tried to follow the existing pattern. I saw that the other handlers had entries in both lists, so I added the new one to both lists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This configuration file isn't related to this feature and in my mind shouldn't be on this commit.
Tomcat logging shouldn't be provided in all case because it's a user customisation. In my case I prefer to keep default tomcat logging file.
Your purpose is to provide a rotation on tomcat catalina.out file, this rotation should be done by logrotate (or any other tool) and is an "OS dependancy". Or if you want a such change do a request on tomcat source, you will get their feed back about a such feature/need.
… uPortal-start, no dependency on uPortal for build
…sak, much better handling of building uPortalaopArchive.jar
Checklist
Description of change