Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providing some improvements on esco-content-menu #303

Merged
merged 8 commits into from
May 14, 2019

Conversation

jgribonvald
Copy link
Contributor

@jgribonvald jgribonvald commented Apr 11, 2019

This provide some improvments :

  • the possibility to set css variable on the content-grid
  • the possibility to remove the content-user from the esco-content-menu via slot
  • the possibility to remove the header-buttons from esco-content-menu via slot
  • the possibility to switch from a slider to the content-grid for the favorite part into esco-content-menu, and from the esco-hamburger-menu
  • fix language detection, based on main document lang property (this permit to be based on the uPortal lang definition).

@ChristianMurphy ChristianMurphy added the work in progress changes are still being developed, don't merge yet label Apr 11, 2019
@jgribonvald jgribonvald changed the title [WIP]: provinding some improvments on esco-content-menu [WIP]: providing some improvments on esco-content-menu Apr 11, 2019
@jgribonvald jgribonvald added the enhancement New feature or request label Apr 11, 2019
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jgribonvald!
When you have a chance could you run npm run format?

@jgribonvald jgribonvald changed the title [WIP]: providing some improvments on esco-content-menu providing some improvments on esco-content-menu Apr 17, 2019
@jgribonvald jgribonvald removed the work in progress changes are still being developed, don't merge yet label Apr 17, 2019
@jgribonvald
Copy link
Contributor Author

Ok this time it's ok and validated by @vrepain (ESUP member)
for an example of the integration see this comment

@ChristianMurphy ChristianMurphy changed the title providing some improvments on esco-content-menu providing some improvements on esco-content-menu Apr 23, 2019
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jgribonvald Nice improvements!
There are a couple merge conflicts, and converting the background boolean attribute to a css variable the are currently blocking this from being merged.
This is close to being merge-able, let me know if you have any questions on the remaining changes requested.

@jgribonvald
Copy link
Contributor Author

@ChristianMurphy : I have to watch so let me some times.

@jgribonvald
Copy link
Contributor Author

I've just rebased to fix merge conflict, I didn't change the background option for now

@ChristianMurphy
Copy link
Member

@jgribonvald there is a merge conflict in ContentGrid.vue.
Is that something you'd be able to take a look at and resolve?

@jgribonvald
Copy link
Contributor Author

@jgribonvald there is a merge conflict in ContentGrid.vue.
Is that something you'd be able to take a look at and resolve?

Yes I will look on, I didn't see the conflict

@jgribonvald
Copy link
Contributor Author

@ChristianMurphy This is rebased and the conflict resolved !

@jgribonvald
Copy link
Contributor Author

jgribonvald commented May 14, 2019

I fixed the favorite-content, when using the content-grid instead of the swipper the context-api and favorites-api parameter were missing to be able to customize the /uPortal context api.

EDIT: for me all seems good now !

@ChristianMurphy ChristianMurphy merged commit 588aceb into uPortal-Project:master May 14, 2019
@jgribonvald jgribonvald deleted the improvments branch May 14, 2019 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants