LibComp 4 issues PR #38
Conversation
|
@relhajj For security & performance, can you change "(Percent)" to maybe "% of Issues"? Otherwise, it is not clear what percent this refers to |
|
@relhajj i could not install the zip file because it says it is incompatible with my IDE. I'm running IntelliJ 20.20.1 |
| returnValue = " " + in.readLine() + "\n" + " " + in.readLine(); | ||
| } | ||
| } | ||
| if (typeofMaven == 2) |
There was a problem hiding this comment.
what does typeOfMaven mean.. what is 1 vs 2? Can you perhaps create an enumeration for this for better readability like MVN_DEP_TYPE = {GRADLE, MAVEN} or something like that ?
|
|
||
| String filePath = this.filePath +"\\"+ project_name +"domains.json"; | ||
| File myFile = new File(filePath); | ||
| JSONObject Mainobj = null; // = new JSONObject(); |
There was a problem hiding this comment.
please start variable names with a small letter mainObj .. probably mainJSONObj?
| } catch (IOException e) { | ||
| e.printStackTrace(); | ||
| } | ||
| JSONObject objM = new JSONObject(content); |
There was a problem hiding this comment.
can you try to use more descriptive variable names? what does objM mean?
|
|
||
|
|
||
|
|
||
| public void EnabledDomain(int domain, String project_name) { |
There was a problem hiding this comment.
this function name is unclear.. is it enableDomain.. is it isEnabledDomain? Don't think it's the latter since it doesn't return a bool but please use function names that indicate the action being taken or the check being performed etc
| } | ||
|
|
||
|
|
||
| private int domainExist(int domain, JSONArray arr) |
There was a problem hiding this comment.
again the function name does not indicate the action/check being performed
| return index; | ||
| } | ||
|
|
||
| public boolean isEnabled(int domain, String project_name) { |
| TextAttributes attributes = EditorColorsManager.getInstance().getGlobalScheme().getAttributes(DebuggerColors.BREAKPOINT_ATTRIBUTES); | ||
| TextAttributes softerAttributes = attributes.clone(); | ||
| boolean dependenciesExists = false; | ||
| int i = 0; |
| TextAttributes attributes = EditorColorsManager.getInstance().getGlobalScheme().getAttributes(DebuggerColors.BREAKPOINT_ATTRIBUTES); | ||
| TextAttributes softerAttributes = attributes.clone(); | ||
| boolean dependenciesExists = false; | ||
| int i = 0; |
| } // end of actionPErformed | ||
|
|
||
|
|
||
| public int detectDependenciesPSI(FileASTNode psinode) |
There was a problem hiding this comment.
so when it says Dependency or Dependencies, does that mean Gradle? I see functions for maven but not gradle.. Should you rename these so it's clear it's for gradle?
| private String librariesURL = "https://smr.cs.ualberta.ca/comparelibraries/api/libraries/?format=json"; | ||
| private String chartsURL = "https://smr.cs.ualberta.ca/comparelibraries/api/charts/?format=json"; | ||
| private String metricsURL = "https://smr.cs.ualberta.ca/comparelibraries/api/metrics/?format=json&latestdate="; | ||
| private String updateUrllink = "https://smr.cs.ualberta.ca/comparelibraries/api/pluginusers/"; |
close issue Highlighting Options in LibComp #10 : user can enable and disable a domain from being highlighted per project. This is done by right clicking on the line and selecting enable/disable
close issue Support for maven files #37 : similar functionality to gradle files but this is for the pom.xml file in maven projects (enable/disable and replacements and adding a comment to the website are all the same) Main difference is the format of the files.
close issue Change plugin group and name #19 : plugin group name has been updated.
close issue Intsallable plugin should work on older versions #22 : plugin should work on current version and all future versions to come from now on.
close issue Move all paths to a config file #36 : all paths have been collected and stored in one location, although they are in the Java DB file not a config file. But the goal of having one location for all URLs is met.
close issue Plugin incompatible with IntellIJ IDEA 2020.2 #40 : based on changed made for issue Intsallable plugin should work on older versions #22, this should also be solved. Package should work on all versions from 2020.1 and onwards from now on.