Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prioritize precision by ensuring more clauses are matched #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

prioritize precision by ensuring more clauses are matched #4

wants to merge 1 commit into from

Conversation

pgwillia
Copy link
Member

@pgwillia pgwillia commented Mar 1, 2019

This is what we've currently configured <str name="mm">2&lt;-1 5&lt;-2 6&lt;90%</str>

mm is Minimum Should Match

If there are 1 or 2 clauses, then both are required.
2<-1
If there is 3, 4 or 5 clauses then all but one is required.
5<-2
If there is 6 clauses then all but two is required.
6<90%
If there are more than 6 clauses then 90% are required.

So for these queries, british missions south pacific (319) has four clauses, three are required. And for british missions "south pacific" (1,358) has three clauses, two are required. (You can see this in the debugged query where ~2 vs ~3 slop is used).

We can simplify this to increase precision. One side-effect of this change might be that there are queries that return zero results that previously returned many.

@pgwillia pgwillia changed the title prioritize precision by ensuring more clauses are matched WIP: prioritize precision by ensuring more clauses are matched Mar 1, 2019
@pgwillia pgwillia changed the title WIP: prioritize precision by ensuring more clauses are matched prioritize precision by ensuring more clauses are matched Jul 22, 2020
@pgwillia pgwillia requested review from a user and mbarnett July 22, 2020 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant