prioritize precision by ensuring more clauses are matched #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what we've currently configured
<str name="mm">2<-1 5<-2 6<90%</str>
mm is Minimum Should Match
If there are 1 or 2 clauses, then both are required.
2<-1
If there is 3, 4 or 5 clauses then all but one is required.
5<-2
If there is 6 clauses then all but two is required.
6<90%
If there are more than 6 clauses then 90% are required.
So for these queries, british missions south pacific (319) has four clauses, three are required. And for british missions "south pacific" (1,358) has three clauses, two are required. (You can see this in the debugged query where ~2 vs ~3 slop is used).
We can simplify this to increase precision. One side-effect of this change might be that there are queries that return zero results that previously returned many.