Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Usage tab link loading for statistics link #1888

Open
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

t-scholtz
Copy link
Contributor

Added capability so that when you load a chart link from the usage tab ie https://xdmod.access-ci.org/index.php#tg_usage?node=statistic_Jobs_nodecount_utilization the usage tab will load that chart, instead of loading the default chart configuration

Note - this does not handle the case for group charts ie https://xdmod.access-ci.org/index.php#tg_usage?node=group_by_Jobs_nodecount which are handled like the old case and just load the default chart instead.

Motivation and Context

This allows users to share usage tab charts, as well as adds the production effort in creating an XDMod Chatbot

html/gui/js/modules/Usage.js Outdated Show resolved Hide resolved
html/gui/js/modules/Usage.js Show resolved Hide resolved
html/gui/js/modules/Usage.js Outdated Show resolved Hide resolved
html/gui/js/modules/Usage.js Show resolved Hide resolved
tests/ui/test/specs/xdmod/usageTab.js Outdated Show resolved Hide resolved
@aestoltm aestoltm mentioned this pull request Jul 31, 2024
3 tasks
Copy link
Contributor

@aestoltm aestoltm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestions for a minor refactor when we know what dimension the url is referring to. There are also a few changes to some of the variable names so they are more consistent with the XDMoD language. I also included a small change so that this can work with the 'Summary Overview' charts. Even though we most likely will not support those charts with the chat bot I think it would be nice to support in the portal.

Please let me know if you have any questions on the suggested changes.

html/gui/js/modules/Usage.js Outdated Show resolved Hide resolved
@aestoltm aestoltm added this to the 11.5.0 milestone Sep 6, 2024
@aestoltm aestoltm added enhancement Enhancement of the functionality of an existing feature Category:Metric Explorer Metric Explorer / Usage labels Sep 6, 2024
@aestoltm aestoltm marked this pull request as ready for review December 10, 2024 14:35
@aestoltm aestoltm dismissed their stale review December 10, 2024 14:35

Stale review

@aestoltm aestoltm requested a review from eiffel777 December 10, 2024 14:36
@aestoltm
Copy link
Contributor

The regex is throwing a sonar warning. Need to confirm if it needs to be adjusted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Metric Explorer Metric Explorer / Usage enhancement Enhancement of the functionality of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants