-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Usage tab link loading for statistics link #1888
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a suggestions for a minor refactor when we know what dimension the url is referring to. There are also a few changes to some of the variable names so they are more consistent with the XDMoD language. I also included a small change so that this can work with the 'Summary Overview' charts. Even though we most likely will not support those charts with the chat bot I think it would be nice to support in the portal.
Please let me know if you have any questions on the suggested changes.
Co-authored-by: Andrew Stoltman <[email protected]>
Co-authored-by: Andrew Stoltman <[email protected]>
The regex is throwing a sonar warning. Need to confirm if it needs to be adjusted. |
Added capability so that when you load a chart link from the usage tab ie https://xdmod.access-ci.org/index.php#tg_usage?node=statistic_Jobs_nodecount_utilization the usage tab will load that chart, instead of loading the default chart configuration
Note - this does not handle the case for group charts ie https://xdmod.access-ci.org/index.php#tg_usage?node=group_by_Jobs_nodecount which are handled like the old case and just load the default chart instead.
Motivation and Context
This allows users to share usage tab charts, as well as adds the production effort in creating an XDMod Chatbot