Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile refactoring changes #1889

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ShixinWu16
Copy link

Description

Changes to support XDMoD database on an external host

Added a check for if the user was created

  • classes/CCR/DB/MySQLHelper.php
  • classes/OpenXdmod/Shared/DatabaseHelper.php

Added a question to get XDMoD host

  • classes/CCR/DB/MySQLHelper.php
  • classes/OpenXdmod/Setup/DatabaseSetup.php

Changed from using bootstrap to entrypoint (in create docker images repo)

  • tests/ci/bootstrap.sh

Updated collation from utf8_general_ci to utf8_unicode_ci

  • configuration/etl/etl_tables.d/*
  • tests/artifacts/xdmod/etlv2/configuration/input/*
  • tests/artifacts/xdmod/etlv2/configuration/output/*
  • tests/unit/lib/ETL/DbModel/*

Motivation and Context

We wanted to split up the docker containers so that each module has their own container.
This would allow us to share our docker images without having to share everything.

Tests performed

Ran all automated tests, changed tests to match new collation sets

Checklist:

  • [ X ] The pull request description is suitable for a Changelog entry
  • [ X ] The milestone is set correctly on the pull request
  • [ X ] The appropriate labels have been added to the pull request

@ryanrath ryanrath added this to the 11.5.0 milestone Jul 29, 2024
@ryanrath ryanrath added Category:Infrastructure Internal infrastructure updates/changes enhancement Enhancement of the functionality of an existing feature maintenance / code quality Improvements and code cleanup. Not a new feature or enhancement to existing functionality. labels Jul 29, 2024
@ShixinWu16 ShixinWu16 force-pushed the file_updates_for_refactoring_docker_files branch from 6ee958a to 16e723d Compare July 29, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Infrastructure Internal infrastructure updates/changes enhancement Enhancement of the functionality of an existing feature maintenance / code quality Improvements and code cleanup. Not a new feature or enhancement to existing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants