Cache Bust attempt #1923
Open
Cache Bust attempt #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do these also need to be updated?
|
The html template is used for the report generator and image export - these get run in a headless chrome with no profile - so there shouldn't be a cache that needs to be busted. We would have seen issues with image export if this was a problem and I don't believe that we have had porblems with that |
aaronweeden
approved these changes
Oct 10, 2024
aaronweeden
requested changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The update from 10.5 to 11.0 had substantial changes to various javascript files mostly due to the plotly updates. However, the filenames themselves didn't change. On our production systems, the document lifetime is set to a year, so Safari and Edge browsers are caching those files and not checking to see if they have been updated (we have etags enabled, but it seems the browsers don't check the etag values, instead they just load from cache).
Motivation and Context
This happens when you browse to XDMoD 11.0 with cached versions of the 10.5 javascript:
Fix is to add a query parameter with the XDMoD version number to all javascript file loads. This means that the browsers see the file from 10.5 as different from 11.0 (e.g. in 10.5 the browser requests "Summary.js" and with this change in 11.0 it will request "Summary.js?version=11.0.0". Which is a different filename and will cause the browser to request it since its not cached. The query parameters are ignored by the webserver when serving a normal file so the file contents are not changed by this request structure.
Tests performed
Installed on my port on dev and confirmed that it will pull it the first time:
and then cache it on subsequent pulls: