Add ability to set character set for load data infile. #1942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trying to load utf8 data properly from xras. The mysql and mariadb docs claim that the character_set_database
is used when load data infile. However I could not get it to work. The only thing that did work was explicitly setting the character set in the load data statement.
Note that the old-school ingestors supportted setting the character set in the load file statement and we use this capability in the classes/DB/PDODBUtf8MultiIngestor.php in the xsede module. It looks like an oversight that this support was not added to the ETLv2 code.
Tests performed
Tested on NAIRR XDMoD:
Old code (note the
character_set_*variables appear to be the correct values):New code: