Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statsd tags #106

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Statsd tags #106

wants to merge 3 commits into from

Conversation

joelmarty
Copy link

Fixes #105

Changes

  • Bump com.datadoghq:java-dogstatsd-client to 4.0.0
  • Pass tags to the statsd client instead of ignoring them
  • Fix tests:
    • Move the StatsdAssertingUdpServer to the test sources
    • Expose the lines failing assertion: since the StatsdAssertingUdpServer runs in another thread, the exception was not picked up by JUnit and the test passed anyway.
    • Test the passed tags, which required to review the implementation and parse back the received metrics: the previous implementation ignored everything after the type field in the metric line.

@CLAassistant
Copy link

CLAassistant commented Apr 21, 2022

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StatsdReporter does not support tags
2 participants