Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue where histogram snapshot mutates its state #126

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Fix issue where histogram snapshot mutates its state #126

merged 1 commit into from
Jun 27, 2024

Conversation

guscastro
Copy link
Contributor

The current HistogramImpl#snapshot implementation ultimately calls CounterImpl#value, which mutates its state. Instead, this PR changes the call to #snapshot.

@CLAassistant
Copy link

CLAassistant commented Jun 14, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@justinjc justinjc merged commit 1d3641c into uber-java:master Jun 27, 2024
4 checks passed
@justinjc justinjc mentioned this pull request Jun 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinjc justinjc justinjc approved these changes

@zmanji zmanji zmanji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guscastro @CLAassistant @zmanji @justinjc