feat(test-utils): Support coverage in BrowserTestDriver #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pessimistress
changed the title
ibgreen
approved these changes
Feb 18, 2024
| @@ -96,6 +98,10 @@ export default class BrowserDriver { | |||
| } | |||
| await Promise.all(promises); | |||
|
|
|||
| if (coverage) { | |||
| await this.page.coverage.startJSCoverage(); | |||
There was a problem hiding this comment.
A few more comments maybe? Are these methods part of puppeteer or installed by the dependency?
| @@ -80,6 +83,15 @@ export default class BrowserTestDriver extends BrowserDriver { | |||
| } | |||
|
|
|||
| const result = await this._openPage(url, config); | |||
|
|
|||
| if (config.coverage) { | |||
| const coverageResult = await this.page?.coverage.stopJSCoverage(); | |||
There was a problem hiding this comment.
Nit: It seems to me that this spreads out the coverage integration across base and subclass... For better encapsulation and symmetry, I feel that startJSCoverage and stopJSCoverage methods should both be called by either the BrowserDriver base class or this class.
|
Closing this for now because We can revisit using puppeteer's native coverage feature at a later time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.