Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Checker Framework 3.48.0 #1030

Merged
merged 6 commits into from
Oct 2, 2024
Merged

Update to Checker Framework 3.48.0 #1030

merged 6 commits into from
Oct 2, 2024

Conversation

msridhar
Copy link
Collaborator

@msridhar msridhar commented Sep 4, 2024

Fixes #1012. Benchmarking shows any perf difference is within the noise.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.54%. Comparing base (f3837e8) to head (2d09507).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1030   +/-   ##
=========================================
  Coverage     87.54%   87.54%           
  Complexity     2165     2165           
=========================================
  Files            85       85           
  Lines          7114     7114           
  Branches       1386     1386           
=========================================
  Hits           6228     6228           
  Misses          458      458           
  Partials        428      428           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 4, 2024

Main Branch:

Benchmark                          Mode  Cnt   Score   Error  Units
AutodisposeBenchmark.compile      thrpt   25   9.155 ± 0.108  ops/s
CaffeineBenchmark.compile         thrpt   25   3.418 ± 0.040  ops/s
DFlowMicroBenchmark.compile       thrpt   25  24.760 ± 0.306  ops/s
NullawayReleaseBenchmark.compile  thrpt   25   1.276 ± 0.020  ops/s

With This PR:

Benchmark                          Mode  Cnt   Score   Error  Units
AutodisposeBenchmark.compile      thrpt   25   9.110 ± 0.057  ops/s
CaffeineBenchmark.compile         thrpt   25   3.379 ± 0.036  ops/s
DFlowMicroBenchmark.compile       thrpt   25  24.833 ± 0.327  ops/s
NullawayReleaseBenchmark.compile  thrpt   25   1.271 ± 0.018  ops/s

@msridhar
Copy link
Collaborator Author

msridhar commented Sep 4, 2024

We'll have to hold off on updating as we're seeing a crash on the input from #1012. Reported upstream as typetools/checker-framework#6785.

@msridhar msridhar changed the title Update to Checker Framework 3.47.0 [WIP] Update Checker Framework Sep 8, 2024
Copy link

github-actions bot commented Oct 2, 2024

Main Branch:

Benchmark                          Mode  Cnt   Score   Error  Units
AutodisposeBenchmark.compile      thrpt   25  10.274 ± 0.079  ops/s
CaffeineBenchmark.compile         thrpt   25   3.779 ± 0.038  ops/s
DFlowMicroBenchmark.compile       thrpt   25  28.748 ± 0.348  ops/s
NullawayReleaseBenchmark.compile  thrpt   25   1.473 ± 0.013  ops/s

With This PR:

Benchmark                          Mode  Cnt   Score   Error  Units
AutodisposeBenchmark.compile      thrpt   25  10.092 ± 0.136  ops/s
CaffeineBenchmark.compile         thrpt   25   3.742 ± 0.054  ops/s
DFlowMicroBenchmark.compile       thrpt   25  28.700 ± 0.242  ops/s
NullawayReleaseBenchmark.compile  thrpt   25   1.478 ± 0.019  ops/s

@msridhar msridhar changed the title [WIP] Update Checker Framework Update to Checker Framework 3.48.0 Oct 2, 2024
@msridhar msridhar marked this pull request as ready for review October 2, 2024 22:56
@msridhar msridhar enabled auto-merge (squash) October 2, 2024 22:57
@msridhar msridhar merged commit e1298df into master Oct 2, 2024
12 checks passed
@msridhar msridhar deleted the cf-3.47.0 branch October 2, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected type: <nulltype> when both operands of a ternary expression are null
2 participants