Increase buffer capacity for mutableRouterEvents flow within RibEvents #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sIncrease buffer capacity for mutableRouterEvents flow within RibEvents
|
|
psteiger
reviewed
Jun 24, 2024
android/gradle.properties
Outdated
| @@ -13,7 +13,7 @@ | |||
| # org.gradle.parallel=true | |||
|
|
|||
| GROUP=com.uber.rib | |||
| VERSION_NAME=0.16.3-SNAPSHOT | |||
There was a problem hiding this comment.
We don't need to bump it now -- the release script bumps it automatically
psteiger
approved these changes
Jun 25, 2024
psteiger
approved these changes
Jun 29, 2024
|
@tyvsmith can you help w/ getting this merged, please? I see the following message:
I'm using my personal GitHub account. cc @dmellorahul |
Done, and fixed the issue with your access. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase buffer capacity for mutableRouterEvents flow within RibEvents.
Description:
The RibEvents flow is consumed by the ribtree plugin. However, that consumption can sometimes be slower than production so we were losing a few events. Making a large buffer size helps fix that.