Fixed FusionJS issue 622 by using ansi-colors instead of ansi-color #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
fusionjs/fusion-cli#622
jcorbin/hexer#17
ansi-color uses octal notation for colors that seems to cause errors when using Babel's es2015 preset which uses strict mode for Javascript. This strict mode doesn't allow hex codes starting with
\0xy, it must start with\u0xyinstead. Instead of attempting to fix very old code within ansi-color, I have changed the package dependency to use a better supported utility called ansi-colors.While making this decision to use ansi-colors, we also could have used chalk. Both are well used and supported, but ansi-colors was a better near drop-in replacement to ansi-color. This change makes the external contract the same, so users of hexer will notice no difference and won't need to change their code at all besides the package version.
It's entirely possible to create a patch or minor version update since this is an internal change that doesn't affect external code.