Split DiskSpaceUtil
function to improve reusability
#370
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for kraken services to know when to clean up their cache, they monitor how much of the disk space on their hosts is utilized with the
DiskSpaceUtil
function. Currently, that function calculates the disk utilization for the whole host.In the future, we want to specifically check the cache directory's disk space utilization, instead of the whole host's. The reason is that cache cleanup should be done close to the cache filling up. While this might be correlated to the host's disk filling up, they are not the same. For example, if the host has a separate file system for the cache, that might be 90% full, whereas the host's overall disk space might be only 20% full.
To allow for checking the disk utilization for a specific directory (and thus the disk it is mounted on), the
DiskSpaceUtil
function is split into two -- one that still does the same thing and another that takes apath
as an argument, to allow for reusability.