Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split DiskSpaceUtil function to improve reusability #370

Closed
wants to merge 1 commit into from

Conversation

Anton-Kalpakchiev
Copy link
Collaborator

@Anton-Kalpakchiev Anton-Kalpakchiev commented Oct 31, 2024

In order for kraken services to know when to clean up their cache, they monitor how much of the disk space on their hosts is utilized with the DiskSpaceUtil function. Currently, that function calculates the disk utilization for the whole host.

In the future, we want to specifically check the cache directory's disk space utilization, instead of the whole host's. The reason is that cache cleanup should be done close to the cache filling up. While this might be correlated to the host's disk filling up, they are not the same. For example, if the host has a separate file system for the cache, that might be 90% full, whereas the host's overall disk space might be only 20% full.

To allow for checking the disk utilization for a specific directory (and thus the disk it is mounted on), the DiskSpaceUtil function is split into two -- one that still does the same thing and another that takes a path as an argument, to allow for reusability.

@Anton-Kalpakchiev Anton-Kalpakchiev changed the title Split disk space util functions to improve reusability Split DiskSpaceUtil function to improve reusability Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants