Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add origin readiness client #374

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Add origin readiness client #374

merged 1 commit into from
Nov 15, 2024

Conversation

Anton-Kalpakchiev
Copy link
Collaborator

As described in #371, all services should implement a "readiness" endpoint, which checks whether the service is ready to serve traffic, i.e. whether it can reach all of its dependencies.

  • Add a client for the origin's readiness endpoint.
  • Additionally, add a ClusterClient (a client which abstracts which origin from the cluster is called).
  • Rework the readiness test to use the client instead of directly calling the endpoint. Also, make each test case run separately (by using t.Run instead of just looping) to follow idiomatic Go.

Copy link
Collaborator

@gkeesh7 gkeesh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments rest looks good please address those.

@Anton-Kalpakchiev Anton-Kalpakchiev merged commit 3b1b193 into master Nov 15, 2024
5 checks passed
@Anton-Kalpakchiev Anton-Kalpakchiev deleted the origin-client branch November 15, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants