Generate mock method with Typed Throw #262
Open
+121
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fummicc1
force-pushed
the
feature/issue-261-typed-throw
branch
from
136cdd3
to
bbb6de0
Compare
fummicc1
force-pushed
the
feature/issue-261-typed-throw
branch
from
c5c877f
to
725c67d
Compare
fummicc1
commented
Jul 15, 2024
Comment on lines
-4
to
-13
| let funcThrow2 = """ | ||
| import Foundation | ||
| /// \(String.mockAnnotation) | ||
| protocol FuncThrow { | ||
| func update<T>(arg1: T, arg2: () throws -> T) rethrows -> T | ||
| func update<T, U>(arg1: T, arg2: @escaping (U) throws -> ()) throws -> ((T) -> (U)) | ||
| } | ||
| """ | ||
|
|
There was a problem hiding this comment.
FYI
This test-fixture is not used and is covered by funcThrow test-fixture. So I deleted it.
| ) | ||
| } | ||
| .first | ||
| } |
There was a problem hiding this comment.
I am not sure if splitting by .whitespace is suitable or not. but this code works in added test-cases.
As far as I investigated,
any Errorcan't be thrown type because it's not a concrete type.some Errorcan't come here due to an issue related to performance (https://github.com/swiftlang/swift-evolution/blob/main/proposals/0413-typed-throws.md#opaque-thrown-error-types).
| @@ -11,7 +11,7 @@ let package = Package( | |||
| .library(name: "MockoloFramework", targets: ["MockoloFramework"]), | |||
| ], | |||
| dependencies: [ | |||
| .package(url: "https://github.com/apple/swift-syntax.git", from: "510.0.1"), | |||
| .package(url: "https://github.com/swiftlang/swift-syntax.git", from: "600.0.0-prerelease-2024-06-12"), | |||
There was a problem hiding this comment.
to use ThrowsClauseSyntax, I updated swift-syntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request, parse typed-throw name from throws clause.