Remove dead codes #271
Merged
Remove dead codes #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Sources/MockoloFramework/Models/Model.swift
# Conflicts: # Sources/MockoloFramework/Operations/UniqueModelGenerator.swift # Sources/MockoloFramework/Utils/InheritanceResolver.swift
# Conflicts: # Sources/MockoloFramework/Models/ClosureModel.swift # Sources/MockoloFramework/Models/MethodModel.swift # Sources/MockoloFramework/Templates/VariableTemplate.swift
# Conflicts: # Sources/MockoloFramework/Templates/MethodTemplate.swift
# Conflicts: # Sources/MockoloFramework/Models/IfMacroModel.swift # Sources/MockoloFramework/Models/MethodModel.swift # Sources/MockoloFramework/Models/Model.swift # Sources/MockoloFramework/Models/VariableModel.swift # Sources/MockoloFramework/Parsers/SwiftSyntaxExtensions.swift
sidepelican
commented
Nov 6, 2024
| @@ -30,13 +39,6 @@ extension SyntaxProtocol { | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| extension AttributeListSyntax { | |||
| var trimmedDescription: String? { | |||
There was a problem hiding this comment.
SwiftSyntax already has trimmedDescription
| } | ||
| } | ||
| let aliasDupes = aliasMap.filter {$0.value.count > 1} | ||
| return aliasDupes.isEmpty ? nil : aliasDupes | ||
| return aliasDupes.isEmpty ? nil : aliasDupes.mapValues {$0.sorted()} |
There was a problem hiding this comment.
The results are now sorted, but I believe there are no compatibility issues.
uhooi
approved these changes
Nov 6, 2024
Co-authored-by: uhooi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a lot of dead code in mockolo due to historical reasons.
With many unused definitions and arguments, they make hard to understand of the code, so I would like to clean up them.
In this PR, I will make some simple deletions and replace some implementations with simpler forms