Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C API] NP_GetType implementation #419

Merged
merged 3 commits into from
Aug 19, 2020
Merged

Conversation

vkuzmin-uber
Copy link
Contributor

Summary:

Continue with basic implementation of a C API for Neuropod. Issue #407

Test Plan:

Added test for input and output tensors.

Copy link
Collaborator

@VivekPanyam VivekPanyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Can we also start adding additional unit tests where necessary instead of just a single integration test covering the C API?

@VivekPanyam
Copy link
Collaborator

(Also, ./tools/lint.sh and ./tools/autofix.sh to fix the formatting issues - https://neuropod.ai/developing/#lint-and-static-analysis)

@VivekPanyam VivekPanyam changed the title [C API] NP_GetType implementation (#409) [C API] NP_GetType implementation Aug 17, 2020
@vkuzmin-uber
Copy link
Contributor Author

Looks good.

Can we also start adding additional unit tests where necessary instead of just a single integration test covering the C API?

Good point. I will update test.

@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #419 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #419      +/-   ##
==========================================
+ Coverage   89.46%   89.47%   +0.01%     
==========================================
  Files          90       90              
  Lines        5193     5199       +6     
==========================================
+ Hits         4646     4652       +6     
  Misses        547      547              
Impacted Files Coverage Δ
source/neuropod/bindings/c/c_api.cc 100.00% <100.00%> (ø)
source/neuropod/bindings/c/np_tensor.cc 80.00% <100.00%> (+5.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c3d499...770d9cf. Read the comment docs.

@VivekPanyam VivekPanyam merged commit fd4dae6 into uber:master Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants