Add missing API versions for Roboelectric #972
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding missing APIS 32 and 33 so they can be resolved by the OkBuck build system
|
|
|
Please update TestExtension.java to the latest preinstrumented verison while we're at it (same PR or separate). Also, it would be good to add a CustomAPI support so we can update this without a PR, but we don't need to block on making that happen now. |
vicmns
force-pushed
the
bump_roboelectric_versions
branch
7 times, most recently
from
57b0727 to
ecdeef0
Compare
vicmns
force-pushed
the
bump_roboelectric_versions
branch
8 times, most recently
from
d278d1e to
dd9f3d5
Compare
Bump preinstrumented version to 4 as found on robo src code. Run okbuck before performing CI tasks to update references
vicmns
force-pushed
the
bump_roboelectric_versions
branch
from
dd9f3d5 to
dafaa7f
Compare
hvvikram
force-pushed
the
master
branch
3 times, most recently
from
b7ce0ff to
815b968
Compare
|
Is this stalled? |
* feat: Add support for exporting raw dependencies plugin can accept two project parameters * exportDependencies: to enable exporting of raw dependencies * exportDependenciesFile: Name with optional relative path from the root of the project where the dependencies will be exported ( default: .okbuck/raw-deps ) Supports exporting raw dependencies in JSON format. ``` ./gradlew okbuck -PexportDependencies=true -PexportDependenciesFile=.okbuck/raw-deps.json ``` * Moved configurations to OKBuckExtension and handle excludeRule to use group:module when both are not blank * * Addressed review comments * Ran google formatter * Autoclose BufferedWriter to flush the contents and close
Add releasing doc
* Add config cleanCacheDir which controls whether to delete the entire cache dir or only the existing dependency rules files, before generating the dependency rule files * Switched to parallel delete * Use TrueFileFilter for directory filter instead of null
…s/okbuck into bump_roboelectric_versions
|
Kind off, I'm still not able to get CI to resolve this artifact.... |
Adding missing APIS 32 and 33 so they can be resolved by the OkBuck build system
Bump preinstrumented version to 4 as found on robo src code. Run okbuck before performing CI tasks to update references
…s/okbuck into bump_roboelectric_versions
|
We should abandon this PR as it's superseded by #983 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding missing APIS 32 and 33 so they can be resolved by the OkBuck build system
Description:
Adding missing APIs levels to Roboelectric manager.