Add reverse implementors index to the partial SCIP loader #23
+196
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
uberzzr
changed the title
JamyDev
reviewed
Oct 7, 2025
src/scip-lib/partialloader/index.go
Outdated
| GetSymbolInformation(symbol string) (*model.SymbolInformation, string, error) | ||
| GetSymbolInformationFromDescriptors(descriptors []model.Descriptor, version string) (*model.SymbolInformation, string, error) | ||
| References(symbol string) (map[string][]*model.Occurrence, error) | ||
| GetImplementationSymbols(symbol string) ([]string, error) |
There was a problem hiding this comment.
Match the other methods by naming this Implementations
Suggested change
| GetImplementationSymbols(symbol string) ([]string, error) | |
| Implementations(symbol string) ([]string, error) |
Comment on lines
371
to
400
| // Fallback: traverse relationships on the abstract symbol if the reverse index is empty or there is error | ||
| symbolInformation, _, err := p.Index.GetSymbolInformation(sourceOccurrence.Symbol) | ||
| if err != nil { | ||
| p.logger.Errorf("failed to get symbol information for %s: %s", sourceOccurrence.Symbol, err) | ||
| return nil, err | ||
| } | ||
| if symbolInformation == nil { | ||
| return []protocol.Location{}, nil | ||
| } | ||
|
|
||
| for _, relationship := range symbolInformation.Relationships { | ||
| if relationship.IsImplementation { | ||
| implementingSymbol, err := model.ParseScipSymbol(relationship.Symbol) | ||
| if err != nil { | ||
| p.logger.Errorf("failed to parse implementing symbol %s: %s", relationship.Symbol, err) | ||
| continue | ||
| } | ||
| implOcc, err := p.GetSymbolDefinitionOccurrence( | ||
| mapper.ScipDescriptorsToModelDescriptors(implementingSymbol.Descriptors), | ||
| implementingSymbol.Package.Version, | ||
| ) | ||
| if err != nil { | ||
| p.logger.Errorf("failed to get definition for implementing symbol %s: %s", relationship.Symbol, err) | ||
| continue | ||
| } | ||
| if implOcc != nil && implOcc.Occurrence != nil { | ||
| locations = append(locations, *mapper.ScipOccurrenceToLocation(implOcc.Location, implOcc.Occurrence)) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Go to implementation is generally interface -> implementing struct(s)/class(es). This block of code would follow the struct -> parent type(s) which is closer to a typeDefinition; that being said, we have fields for type definition in the relationship as well, so now we'd be splitting hairs about expected behavior.
I think we may want to put this behind a setting (default false/disabled) to let us play with this in different language scip indices, since it's generally not the accurate intended behavior.
There was a problem hiding this comment.
Thanks, removed the fallback logic. We can put this behind a feature flag in subsequent PRs if we need it.
Comment on lines
+63
to
+64
| implementorsMu sync.RWMutex | ||
| ImplementorsBySymbol map[string]map[string]struct{} |
There was a problem hiding this comment.
Was this put as a map on the main index type because there isn't an easy way to attach it to a treeNode during the indexing process? We probably want to change this when we come up with the multiple step index load process.
There was a problem hiding this comment.
Yes, the prefeix tree merging happens after scanning, and the nodes are versioned and pruned, cross-tree mutability may complicate concurrency and correctness
## Description The original goimports fix suggests `Run 'bazel run //tools:goimports_fix' to fix formatting` however there is no such target 'goimports_fix' in package 'tools'. To enable goimports fix mode we need to run `bazel run //tools:goimports -- fix` ## Type of Change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation update - [ ] Refactoring (no functional changes) - [ ] Performance improvement - [ ] Test improvement ## Component(s) Affected - [ ] Language Server (ULSP) - [ ] SCIP Generation (Python utilities) - [ ] VS Code/Cursor Extension - [ ] Java Aggregator - [ ] Build System (Bazel) - [ ] Documentation - [X] Tests ## Testing - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes (`bazel test //...`) - [X] I have tested this manually with a real project ### Manual Testing Details Describe how you tested these changes: - IDE used for testing: - Project(s) tested against: - Specific features/scenarios verified: ## Checklist - [ ] My code follows the existing code style and conventions - [X] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] I have updated BUILD.bazel files if I added new source files - [X] My changes generate no new warnings - [ ] Any dependent changes have been merged and published ## Screenshots/Logs (if applicable) Include any relevant screenshots, logs, or output that demonstrates the changes. ## Related Issues Fixes #(issue number) Closes #(issue number) Related to #(issue number) ## Additional Notes Any additional information that reviewers should know about this PR.
JamyDev
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a reverse implementors index to the partial SCIP loader that maps each abstract/interface symbol to its implementing symbols, built during index load by reading IsImplementation relationships. Also implemented the registry-level implementation handler to be used in "gotoImplementation" later. This handler resolves the symbol uses the reverse index to fetch implementors, resolves each implementor to its definition location, and returns those as LSP locations. If the reverse index has no entry (e.g., incomplete data), it falls back to scanning the symbol’s relationships to find implementors before resolving their locations.
Type of Change
Component(s) Affected
Testing
bazel test //...)Manual Testing Details
Describe how you tested these changes:
Checklist
Screenshots/Logs (if applicable)
Include any relevant screenshots, logs, or output that demonstrates the changes.
Related Issues
Fixes #(issue number)
Closes #(issue number)
Related to #(issue number)
Additional Notes
Any additional information that reviewers should know about this PR.