Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sample consumer to commit after processing the event #17

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Fix sample consumer to commit after processing the event #17

merged 2 commits into from
Apr 8, 2024

Conversation

suez1224
Copy link
Contributor

@suez1224 suez1224 commented Apr 5, 2024

Context:
fix the bug that sample consumer does not commit when after processing events.

Test:
run locally and verified the fix

@CLAassistant
Copy link

CLAassistant commented Apr 5, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ericzhifengchen ericzhifengchen self-assigned this Apr 8, 2024
ericzhifengchen
ericzhifengchen approved these changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@ericzhifengchen ericzhifengchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you contribution! looks good to me

@ericzhifengchen ericzhifengchen merged commit 2644da2 into uber:main Apr 8, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericzhifengchen ericzhifengchen ericzhifengchen approved these changes

Assignees

@ericzhifengchen ericzhifengchen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suez1224 @CLAassistant @ericzhifengchen