Don't animate edited line

ubergeek42 · Dec 7, 2024 · 0815d47 · 0815d47
1 parent 963f7a4
commit 0815d47
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 3 deletions.
diff --git a/app/src/main/java/com/ubergeek42/WeechatAndroid/adapters/ChatLinesAdapter.kt b/app/src/main/java/com/ubergeek42/WeechatAndroid/adapters/ChatLinesAdapter.kt
@@ -218,7 +218,7 @@ class ChatLinesAdapter @MainThread constructor(
     private var style = 0
 
     @AnyThread @Synchronized private fun onLinesChanged(
-        animation: Animation = Animation.Default,
+        animation: Animation? = Animation.Default,
         diffLineContents: Boolean = false
     ) = ulet(buffer) { buffer ->
         val thisUpdateStep = synchronized (updateLock) { ++updateStep }
@@ -238,7 +238,7 @@ class ChatLinesAdapter @MainThread constructor(
 
             diffResult.dispatchUpdatesTo(this@ChatLinesAdapter)
 
-            uiLines.setAnimation(animation)
+            if (animation != null) uiLines.setAnimation(animation)
 
             if (uiLines.onBottom) {
                 uiLines.scrollToPosition(itemCount - 1)
@@ -267,6 +267,10 @@ class ChatLinesAdapter @MainThread constructor(
         onLinesChanged(Animation.LastLineAdded)
     }
 
+    @WorkerThread override fun onLineReplaced() {
+        onLinesChanged(null, diffLineContents = true)
+    }
+
     @WorkerThread override fun onTitleChanged() {
         onLinesChanged()
     }

diff --git a/app/src/main/java/com/ubergeek42/WeechatAndroid/fragments/BufferFragment.kt b/app/src/main/java/com/ubergeek42/WeechatAndroid/fragments/BufferFragment.kt
@@ -483,6 +483,10 @@ class BufferFragment : Fragment(), BufferEye {
         linesAdapter?.onLineAdded()
     }
 
+    @WorkerThread override fun onLineReplaced() {
+        linesAdapter?.onLineReplaced()
+    }
+
     @MainThread override fun onGlobalPreferencesChanged(numberChanged: Boolean) {
         linesAdapter?.onGlobalPreferencesChanged(numberChanged)
     }

diff --git a/app/src/main/java/com/ubergeek42/WeechatAndroid/relay/Buffer.kt b/app/src/main/java/com/ubergeek42/WeechatAndroid/relay/Buffer.kt
@@ -355,6 +355,10 @@ class Buffer @WorkerThread constructor(
         bufferEyes.forEach { it.onLineAdded() }
     }
 
+    @WorkerThread fun onLineReplaced() {
+        bufferEyes.forEach { it.onLineReplaced() }
+    }
+
     var style = 0
 
     @MainThread fun onGlobalPreferencesChanged(numberChanged: Boolean) {

diff --git a/app/src/main/java/com/ubergeek42/WeechatAndroid/relay/BufferEye.kt b/app/src/main/java/com/ubergeek42/WeechatAndroid/relay/BufferEye.kt
@@ -12,6 +12,9 @@ interface BufferEye {
     // 1 line added on bottom
     @WorkerThread fun onLineAdded()
 
+    // line was replaced via _buffer_line_data_changed
+    @WorkerThread fun onLineReplaced()
+
     // indicates changed title
     @WorkerThread fun onTitleChanged()
 

diff --git a/app/src/main/java/com/ubergeek42/WeechatAndroid/relay/BufferList.kt b/app/src/main/java/com/ubergeek42/WeechatAndroid/relay/BufferList.kt
@@ -399,7 +399,7 @@ object BufferList {
                 val spec = LineSpec(entry)
                 findByPointer(spec.bufferPointer)?.let { buffer ->
                     buffer.replaceLine(spec.toLine())
-                    buffer.onLinesListed()
+                    buffer.onLineReplaced()
                 }
             }
         }